controller: unlabel nodes when pool is deleted - #140
Open
cheesesashimi wants to merge 1 commit into
Open
Conversation
cheesesashimi
force-pushed
the
zzlotnik/fix-node-unlabelling
branch
2 times, most recently
from
August 13, 2026 17:08
2490e20 to
3b61e84
Compare
alicefr
approved these changes
Aug 14, 2026
Collaborator
|
@cheesesashimi thanks, it looks great! |
Whenever a BootcNodePool is deleted, the nodes which belong to that pool were still being managed because the labels were not removed from the nodes which belong to that pool. This meant that the daemon continued to run on those nodes. Adding a finalizer to the pool blocks deletion until all of the nodes which belong to that pool have been unlabeled. Assisted-by: AI Signed-off-by: Zack Zlotnik <zzlotnik@redhat.com>
cheesesashimi
force-pushed
the
zzlotnik/fix-node-unlabelling
branch
from
August 14, 2026 13:03
3b61e84 to
c60920c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a BootcNodePool is deleted, the nodes which belong to that pool were still being managed because the labels were not removed from the nodes which belong to that pool. This meant that the daemon continued to run on those nodes. Adding a finalizer to the pool blocks deletion until all of the nodes which belong to that pool have been unlabeled.
This fixes #138